-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the args_default usage #250
Conversation
While args_defaults is compatible with the original usage, the value of argments can also be set through function call usage. Signed-off-by: yuanwu <[email protected]>
@yuanwu2017 your description is unclear. If your PR fixes an existing issue, please describe what issue does it fix with an example. If your PR is a new feature, please give an example of when it is helpful. |
We are integrating the Megatron-deepspeed into Ray. We need initialize_megatron to initialize megatron by passing in function arguments instead of arguments from the startup command.
|
with the patch, I run pretrain_llama2_distributed.sh which set --tokenizer-type GPTSentencePieceTokenizer, but in pretrain_gpt.py args_defaults={'tokenizer_type': 'GPT2BPETokenizer'}, as result, tokenizer-type=GPT2BPETokenizer, but for llama2, tokenizer-type should be GPTSentencePieceTokenizer, how to solve it? ths |
This reverts commit 3095a51.
This reverts commit 3095a51.
Sorry for the introduction of bug and your inconvenience. I reverted the patch and made a new one. |
thx |
* Revert "Modify the args_default usage (#250)" This reverts commit 3095a51. * Add the external arguments Add the external_arguments for passing the arguments from function call. Signed-off-by: yuanwu <[email protected]> --------- Signed-off-by: yuanwu <[email protected]>
* Revert "Modify the args_default usage (microsoft#250)" This reverts commit 3095a51. * Add the external arguments Add the external_arguments for passing the arguments from function call. Signed-off-by: yuanwu <[email protected]> --------- Signed-off-by: yuanwu <[email protected]>
* Revert "Modify the args_default usage (microsoft#250)" This reverts commit 3095a51. * Add the external arguments Add the external_arguments for passing the arguments from function call. Signed-off-by: yuanwu <[email protected]> --------- Signed-off-by: yuanwu <[email protected]>
While args_defaults is compatible with the original usage, the value of argments can also be set through function call usage.