[python-package] ensure 'build-python.sh' always reinstalls (fixes #5906) #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
guolinke,
StrikerRUS and
shiyu1994
as code owners
jameslamb
changed the title
jameslamb
changed the title
jmoralez
approved these changes
Jun 10, 2023
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5906.
On
master,build-python.sh installwill not update the installed version oflightgbmif that version has already been installed. For example:sh build-python.sh install sh build-python.sh install # Requirement already satisfied: lightgbm in ../mambaforge/lib/python3.9/site-packages (3.3.5.99)This PR proposes modifying
build-python.shsuch that it'll always install the version it's just built, regardless of what's already installed. I think that is closer to what is expected when building from sources cloned from GitHub, and it also makes local development a bit more reliable and convenient (no need topip uninstalleach time you rebuild).Notes for Reviewers
The relevant code for installing with
--precompiledoesn't need to change, aspython setup.py installwill always reinstall over an existing version.LightGBM/build-python.sh
Line 307 in ad487fe