Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] add more type annotations in basic.py #5812

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Mar 30, 2023

Contributes to #3756.

Adds more type annotations in basic.py.

How I tested this

Checked with mypy, confirmed that no new errors are introduced relative to master.

mypy --ignore-missing-imports python-package/lightgbm

python-package/lightgbm/basic.py Outdated Show resolved Hide resolved
@jameslamb jameslamb requested a review from jmoralez March 31, 2023 03:17
@jameslamb jameslamb merged commit da5160c into master Mar 31, 2023
@jameslamb jameslamb deleted the ci/mypy-more-basic-types branch March 31, 2023 17:35
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants