Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused variables from bin.cpp #5801

Merged
merged 2 commits into from
Mar 29, 2023
+0 −14
Merged

remove unused variables from bin.cpp #5801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feba094
remove unused variables from bin.cpp
jmoralez Mar 23, 2023
716fb5c
merge master
jmoralez Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/io/bin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,20 +160,6 @@ namespace LightGBM {
const std::vector<double>& forced_upper_bounds) {
std::vector<double> bin_upper_bound;

// get list of distinct values
int left_cnt_data = 0;
int cnt_zero = 0;
int right_cnt_data = 0;
for (int i = 0; i < num_distinct_values; ++i) {
if (distinct_values[i] <= -kZeroThreshold) {
left_cnt_data += counts[i];
} else if (distinct_values[i] > kZeroThreshold) {
right_cnt_data += counts[i];
} else {
cnt_zero += counts[i];
}
}

// get number of positive and negative distinct values
int left_cnt = -1;
for (int i = 0; i < num_distinct_values; ++i) {
Expand Down