Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused variables from bin.cpp #5801

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

jmoralez
Copy link
Collaborator

Removes unused variables from bin.cpp. Addresses the following warnings:

io/bin.cpp:165:9: warning: variable 'cnt_zero' set but not used [-Wunused-but-set-variable]
    int cnt_zero = 0;
        ^
io/bin.cpp:164:9: warning: variable 'left_cnt_data' set but not used [-Wunused-but-set-variable]
    int left_cnt_data = 0;
        ^
io/bin.cpp:166:9: warning: variable 'right_cnt_data' set but not used [-Wunused-but-set-variable]
    int right_cnt_data = 0;
        ^

Sample logs

@jmoralez jmoralez marked this pull request as ready for review March 23, 2023 21:22
@jameslamb jameslamb self-requested a review March 29, 2023 03:32
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, nice find! Thank you.

@jameslamb jameslamb merged commit 1113cb7 into master Mar 29, 2023
@jameslamb jameslamb deleted the bin-cpp-unused-warnings branch March 29, 2023 03:34
ClaudioSalvatoreArcidiacono added a commit to ClaudioSalvatoreArcidiacono/LightGBM that referenced this pull request Jun 5, 2023
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants