[python-package] ignore some mypy errors in _DaskLGBMModel #5774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3867.
Resolves the following
mypy
errors.Those errors all come from the fact that
_DaskLGBMModel
is used as a mixin alongsidelightgbm.sklearn.LGBMModel
...LightGBM/python-package/lightgbm/dask.py
Line 1111 in 1585ee1
... and references methods and attributes that it expects to come from
lightgbm.sklearn.LGBMModel
LightGBM/python-package/lightgbm/dask.py
Line 1098 in 1585ee1
There is in theory a way to handle this situation with
typing.Protocol
(https://mypy.readthedocs.io/en/stable/more_types.html#mixin-classes), but I couldn't figure it out tonight. So for now, given that these methods are all covered well by the many unit tests, this PR proposes just ignoring these errors frommypy
.