Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] fix mypy error about ctypes array creation #5726

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

jameslamb
Copy link
Collaborator

Contributes to #3756
Contributes to #3867.

Fixes the following mypy.

python-package/lightgbm/basic.py:315: error: "int" not callable  [operator]
python-package/lightgbm/basic.py:315: error: Unsupported operand types for * ("type" and "int")  [operator]

Notes for Reviewers

Using the * operator is the expected way to create a C array using ctypes, but mypy is confused about it.

Docs: https://docs.python.org/3/library/ctypes.html#arrays

This is a frequently-run code path covered by lots of tests, so I think just ignoring this warning from mypy is safe.

@jameslamb jameslamb merged commit 77132aa into master Feb 27, 2023
@jameslamb jameslamb deleted the ci/mypy-ctypes-arrays branch February 27, 2023 04:05
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants