Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check feature indexes in forced split file (fixes #5517) #5653

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

btrotta
Copy link
Collaborator

@btrotta btrotta commented Dec 30, 2022

When constructing booster, traverse the tree of forced splits and check that all split features have index less than or equal to the maximum feature index in the dataset.

Fixes #5517

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for picking this up!

I tested locally and can confirm that the new test segfaults on latest master and passes with this fix 🎉

@jameslamb jameslamb merged commit f84bfcf into master Dec 30, 2022
@jameslamb jameslamb deleted the check-split-feature-index branch December 30, 2022 06:35
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forcedsplits does not check features index boundary
2 participants