[docs] update cran-comments.md for v3.3.4 release #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
approved these changes
Dec 25, 2022
jmoralez
reviewed
Dec 25, 2022
|
|
||
| Submitted with the following comment: | ||
|
|
||
| > This submission contains {lightgbm} 3.3.3. |
There was a problem hiding this comment.
Shouldn't this be 3.3.4?
There was a problem hiding this comment.
ugh yes you're right, sorry
There was a problem hiding this comment.
Sorry for the late review
There was a problem hiding this comment.
ha no problem at all! You are not on a 24/7 on-call rotation here 😂
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3.4 of the R package has been released to CRAN (#5619 (comment), #5618 (comment)).
See https://cran.r-project.org/web/checks/check_results_lightgbm.html
This PR proposes updating
cran-comments.mdto reflect that.