[ci] make GitHub Actions branch protection stricter (fixes #5501) #5645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5501.
Following advice in that issue and in https://github.com/orgs/community/discussions/26733#discussioncomment-3253155, this proposes two changes to the project's GitHub Actions jobs.
This will make use of GitHub auto-merging more reliable, and reduce the risk of accidentally merging PRs where some CI jobs are failing.
Notes for Reviewers
@guolinke @shiyu1994 can you please go into the branch protection for
master
at https://github.com/microsoft/LightGBM/settings/branches and modify the sectionRequire status checks to pass before merging
?The following should be checked as required:
all-cuda-jobs-successful
(GitHub Actions)all-optional-checks-successful
(GitHub Actions)all-python-package-jobs-successful
(GitHub Actions)all-r-package-jobs-successful
(GitHub Actions)all-static-analysis-jobs-successful
(GitHub Actions)And the following should be unchecked:
all-successful
(GitHub Actions)I think that only the two of you have permissions in this repo to modify that.