-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDA] Add quantile regression objective for new CUDA version #5605
Conversation
update log in test_register_logger
…oft/LightGBM into cuda/objective-regression
add test cases for regression objectives
…oft/LightGBM into cuda/objective-regression
It is weird that
should arise when no related code of Note that for cuda 10.0, in master branch we've already used a smaller shared memory size than the claimed maximum LightGBM/include/LightGBM/cuda/cuda_row_data.hpp Lines 22 to 27 in 8811063
It is unclear to me why adding code in this PR will have to make the @guolinke Do you have any idea? |
how many bytes were exceeded? It looks quite large. are there any functions that possibly inherit or call other functions with shared memory? |
0xcbfc - 0xc000 = 0x0bfc = 3068 bytes
No. The code compiles with cuda 11.0 but not with cuda 10.0. |
@guolinke Let me adjust the |
Just use binary search to find out that the maximum allowed value is 5176. |
@guolinke This is ready for review. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Add quantile regression objective for new CUDA version.