Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Add feature interaction constraint for cuda_exp (fix #4785) #5474

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

shiyu1994
Copy link
Collaborator

@shiyu1994 shiyu1994 commented Sep 7, 2022

Add feature interaction constraint for cuda_exp. This is to fix #4785.

@shiyu1994 shiyu1994 requested a review from btrotta September 7, 2022 09:03
@shiyu1994 shiyu1994 changed the title [CUDA] Add feature interaction constraint for cuda_exp [CUDA] Add feature interaction constraint for cuda_exp (fix #4785) Sep 7, 2022
@shiyu1994 shiyu1994 merged commit 1444a74 into master Sep 7, 2022
@shiyu1994 shiyu1994 deleted the cuda/feature-interaction-constraint branch September 7, 2022 15:54
@jameslamb
Copy link
Collaborator

@shiyu1994 did you use admin powers to merge this despite failing CI checks?

It looks like most CUDA CI jobs are failing.

https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true

Screen Shot 2022-09-07 at 11 19 52 AM

@shiyu1994
Copy link
Collaborator Author

bba92b5 has passed all the tests. And a883479 just changes a comment. And the tests failed simply because the branch is already merged.

Syncing repository: microsoft/LightGBM
[11](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:12)
git version
[12](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:13)
git version 2.17.1
[13](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:14)
git init "/home/guoke/actions-runner/_work/LightGBM/LightGBM"
[14](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:15)
Initialized empty Git repository in /home/guoke/actions-runner/_work/LightGBM/LightGBM/.git/
[15](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:16)
git remote add origin https://github.com/microsoft/LightGBM
[16](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:17)
git config gc.auto 0
[17](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:18)
git config --get-all http.https://github.com/microsoft/LightGBM.extraheader
[18](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:19)
git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress --no-recurse-submodules --depth=5 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/5474/merge:refs/remotes/pull/5474/merge
[19](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:20)
Error: fatal: Couldn't find remote ref refs/pull/5474/merge
[20](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:21)
Warning: Git fetch failed with exit code 128, back off 3.858 seconds before retry.
[21](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:22)
git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress --no-recurse-submodules --depth=5 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/5474/merge:refs/remotes/pull/5474/merge
[22](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:23)
Error: fatal: Couldn't find remote ref refs/pull/5474/merge
[23](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:24)
Warning: Git fetch failed with exit code 128, back off 4.857 seconds before retry.
[24](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:25)
git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress --no-recurse-submodules --depth=5 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/5474/merge:refs/remotes/pull/5474/merge
[25](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:26)
Error: fatal: Couldn't find remote ref refs/pull/5474/merge
[26](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:27)
Error: Git fetch failed with exit code: 128
[27](https://github.com/microsoft/LightGBM/runs/8229456885?check_suite_focus=true#step:4:28)
Error: Exit code 1 returned from process: file name '/home/guoke/actions-runner/bin.2.296.1/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Repository.v1_0.CheckoutTask, Runner.Plugins"'.

@jameslamb
Copy link
Collaborator

oooo ok I see, thanks @shiyu1994

I normally would say we should wait for all of CI to run successfully before merging, but I understand that you're actively working on this part of the code right now and all other non-CUDA CI passed, so I think it was ok this time.

@shiyu1994
Copy link
Collaborator Author

@jameslamb Thanks for your kind understanding.

@jameslamb
Copy link
Collaborator

jameslamb commented Sep 7, 2022

thank YOU for all your work on cuda_exp! really exciting to see the progress 😊

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CUDA] Feature Interaction Constraints on New CUDA Version
4 participants