Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] fix mypy errors about callbacks #5450

Merged
merged 2 commits into from
Aug 30, 2022
Merged

[python-package] fix mypy errors about callbacks #5450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c676023
[python-package] fix mypy errors about callbacks
jameslamb Aug 30, 2022
081cce3
revert unnecessary import
jameslamb Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions python-package/lightgbm/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,14 +685,14 @@ def cv(

# setup callbacks
if callbacks is None:
callbacks = set()
callbacks_set = set()
else:
for i, cb in enumerate(callbacks):
cb.__dict__.setdefault('order', i - len(callbacks))
callbacks = set(callbacks)
callbacks_set = set(callbacks)

if "early_stopping_round" in params:
callbacks.add(
callbacks_set.add(
callback.early_stopping(
stopping_rounds=params["early_stopping_round"],
first_metric_only=first_metric_only,
Expand All @@ -704,10 +704,10 @@ def cv(
)
)

callbacks_before_iter = {cb for cb in callbacks if getattr(cb, 'before_iteration', False)}
callbacks_after_iter = callbacks - callbacks_before_iter
callbacks_before_iter = sorted(callbacks_before_iter, key=attrgetter('order'))
callbacks_after_iter = sorted(callbacks_after_iter, key=attrgetter('order'))
callbacks_before_iter_set = {cb for cb in callbacks_set if getattr(cb, 'before_iteration', False)}
callbacks_after_iter_set = callbacks_set - callbacks_before_iter_set
callbacks_before_iter = sorted(callbacks_before_iter_set, key=attrgetter('order'))
callbacks_after_iter = sorted(callbacks_after_iter_set, key=attrgetter('order'))

for i in range(num_boost_round):
for cb in callbacks_before_iter:
Expand Down