-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ROC-AUC metric for classification model in examples #5440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
In the future when you make contributions here (or in any open source project on GitHub), I strongly recommend creating a branch on your fork instead of directly pushing to main
/ master
.
Once this pull request is merged, you'll need to either delete your fork or do some manual rebasing and force pushing on master
in your fork, since we squash all commits from PRs into a single commit when merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixes #5397.
I think use rmse for classification module is inappropriate. So I use roc_auc_score replace mean_squared_error.
the reason of this update is show in the below link. #5397 (comment)
@jameslamb