Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ROC-AUC metric for classification model in examples #5440

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

Green-16
Copy link
Contributor

@Green-16 Green-16 commented Aug 25, 2022

Fixes #5397.

I think use rmse for classification module is inappropriate. So I use roc_auc_score replace mean_squared_error.
the reason of this update is show in the below link. #5397 (comment)

@jameslamb

examples/python-guide/advanced_example.py Outdated Show resolved Hide resolved
examples/python-guide/advanced_example.py Outdated Show resolved Hide resolved
examples/python-guide/advanced_example.py Outdated Show resolved Hide resolved
@jameslamb jameslamb added the doc label Aug 29, 2022
@Green-16 Green-16 requested review from StrikerRUS and removed request for jmoralez and guolinke August 29, 2022 07:11
@jameslamb jameslamb changed the title Fix the metric for classification module in python example Use ROC-AUC metric for classification model in examples Aug 29, 2022
@jameslamb jameslamb self-requested a review August 29, 2022 15:14
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

In the future when you make contributions here (or in any open source project on GitHub), I strongly recommend creating a branch on your fork instead of directly pushing to main / master.

Once this pull request is merged, you'll need to either delete your fork or do some manual rebasing and force pushing on master in your fork, since we squash all commits from PRs into a single commit when merging.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@StrikerRUS StrikerRUS merged commit 1835247 into microsoft:master Aug 30, 2022
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why the lightGBM use rmse for classification module?
3 participants