Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] [R-package] propagate the best iteration of cvbooster into the individual boosters #5066

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

jmoralez
Copy link
Collaborator

This propagates the best_iteration attribute in the Python package and the best_iter attribute in the R package from the CV Booster to each individual booster in the boosters list. In the Python package this ensures that calling CVBooster.predict uses the best iteration in all boosters (closes #4777).

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

Can you please add [python-package] [R-package] to the description so people reading the release notes will be able to identify that this PR affected those components?

@jmoralez jmoralez changed the title propagate the best iteration of cvbooster into the individual boosters [python package] [R package] propagate the best iteration of cvbooster into the individual boosters Mar 12, 2022
@jmoralez jmoralez changed the title [python package] [R package] propagate the best iteration of cvbooster into the individual boosters [python-package] [R-package] propagate the best iteration of cvbooster into the individual boosters Mar 12, 2022
@StrikerRUS StrikerRUS merged commit 9a4e706 into microsoft:master Mar 12, 2022
@jmoralez jmoralez deleted the cv-boosters-best-iter branch March 12, 2022 19:25
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] CVBooster.predict does not use the best iteration
3 participants