Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update categorical feature description in Advanced Topics #5044

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS added the doc label Mar 2, 2022
@StrikerRUS StrikerRUS requested a review from jmoralez March 2, 2022 23:40
@StrikerRUS StrikerRUS requested a review from jameslamb as a code owner March 2, 2022 23:40
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is much clearer, thank you very much for doing this!

@StrikerRUS
Copy link
Collaborator Author

This description is much clearer, thank you very much for doing this!

All kudos should go to @jmoralez . I just inserted his wording into one more place in docs.

@StrikerRUS StrikerRUS merged commit 0ef8fe0 into master Mar 5, 2022
@StrikerRUS StrikerRUS deleted the cat_feature_doc branch March 5, 2022 01:36
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python] docs say categorical features must be encoded as int, but pandas categorical columns work
4 participants