[python] fixes for supporting 2d numpy arrays for predictions, grads and hess in multiclass custom objective and eval #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in multiclass custom objective
StrikerRUS
requested review from
henry0312,
shiyu1994,
jameslamb,
hzy46 and
tongwu-sh
as code owners
jmoralez
reviewed
Feb 23, 2022
jmoralez
changed the title
Co-authored-by: José Morales <[email protected]>
|
@StrikerRUS @jmoralez Thank you for the fix! I'll be more careful next time when reviewing a python PR. |
jmoralez
approved these changes
Feb 25, 2022
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hadn't had a chance to review #4925, so I'm proposing some fixes and my suggestions in a form of a separate follow-up PR. Sorry about that.