Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Fix custom objective detection in print.lgb.Booster() #4941

Merged
merged 4 commits into from
Jan 9, 2022

Conversation

StrikerRUS
Copy link
Collaborator

As the best of my knowledge, string comparison in R is case-sensitive. I think it's better to use lowercased "none" string value for objective parameter to avoid errors.

if (!private$set_objective_to_none) {
self$reset_parameter(params = list(objective = "none"))
private$set_objective_to_none <- TRUE
}

if (obj == "none") {
obj <- "custom"
}

@StrikerRUS StrikerRUS added the fix label Jan 9, 2022
@StrikerRUS StrikerRUS marked this pull request as ready for review January 9, 2022 01:12
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this change and the simplification in print.lgb.Booster(), thanks!

@jameslamb jameslamb merged commit a6d1f19 into master Jan 9, 2022
@jameslamb jameslamb deleted the r_obj_compare branch January 9, 2022 03:22
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants