Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][sklearn] unify values of best_iteration for sklearn and standard APIs #4845

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Do not replace default 0 with None in sklearn wrapper.

booster.best_iteration = 0

Refer to #4574 (comment).

@StrikerRUS StrikerRUS marked this pull request as ready for review December 2, 2021 15:31
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! Glad to be able to remove a little complexity. Thanks for waiting until 4.0 for this change.

@jameslamb jameslamb merged commit 12915d5 into master Dec 5, 2021
@jameslamb jameslamb deleted the sklearn_best_iter branch December 5, 2021 05:10
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants