-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Fix CI job for R artifact #4811
Conversation
Compilation for
Need use |
Seems that using dev versions of R and Rscript helped. |
@jameslamb You can find resulted artifact here: https://dev.azure.com/lightgbm-ci/_apis/resources/Containers/6904809/R-package?itemPath=R-package%2Flightgbm-3.3.1.99-r-cran.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me!
I'm comfortable using RD
in the wch1/r-debug1
image because:
- We're only creating a source package, so I'm not worried about an alternative R build generating different artifacts.
- The package will be tested against
r-devel
when uploaded to CRAN anyway, so there's no risk of "created a package using a non-standard version of R that breaks things on a CRAN submission".
I pulled the artifact created from this PR's most recent CI run (#4811 (comment)) and ran R CMD check --as-cran
on it, just on my Mac (R 4.1.1 from CRAN, macOS 11.14). No issues found.
So I think it's ok to merge this! (after reverting the commented-out condition line). Thanks for working through this, sorry I didn't think of it in #4775 .
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixed #4810.
DO NOT MERGE before uncommenting
# condition: not(startsWith(variables['Build.SourceBranch'], 'refs/pull/'))
.