Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR and commits to merge back #846

Closed
Laurae2 opened this issue Aug 18, 2017 · 6 comments
Closed

PR and commits to merge back #846

Laurae2 opened this issue Aug 18, 2017 · 6 comments

Comments

@Laurae2
Copy link
Contributor

Laurae2 commented Aug 18, 2017

@guolinke Do you have an idea which PRs and commits should be merged back to master branch?

I'm thinking about the following:

Unsure if possible in the current state:

There are also your commits I'm missing as they don't appear in the PRs / commit history.

@henry0312
Copy link
Contributor

oh my god...

@guolinke
Copy link
Collaborator

sorry, I will add them back

@henry0312
Copy link
Contributor

henry0312 commented Aug 18, 2017

If you don't want to lose contributors, don't do any force push to master or change history of master, I think...
Good luck, @guolinke!

@wxchan
Copy link
Contributor

wxchan commented Aug 18, 2017

What happened?

@henry0312
Copy link
Contributor

To revert the direct support of categorical feature probably, he returned master to 64e5209, although v2.0.6 still exists.
cf. 4181fd9

@guolinke
Copy link
Collaborator

guolinke commented Aug 18, 2017

used cherry-pick to add these PR back.

@henry0312 sorry, I need to do this.
@wxchan sorry, your if-else change cannot be added now, I will try to add it back in future.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants