Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Check categorical feature bin number for warning causes Segmentfault when there are features being ignored #5145

Closed
shiyu1994 opened this issue Apr 12, 2022 · 1 comment · Fixed by #5146 or #5258
Labels

Comments

@shiyu1994
Copy link
Collaborator

Description

In #4448, a check for the number of bins in categorical features is introduced. However, in

if (bin_mappers[i]->bin_type() == BinType::CategoricalBin && bin_mappers[i]->num_bin() > max_bin_for_this_feature) {

the nullable of bin_mappers[i] is not check, which can cause segment fault when there exist features being ignored.

Environment info

LightGBM version or commit hash:
Latest master

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
1 participant