Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] [docs]: weights params description should read weights should be non-negative #4921

Closed
TremaMiguel opened this issue Dec 30, 2021 · 7 comments · Fixed by #5013
Assignees
Labels

Comments

@TremaMiguel
Copy link
Contributor

Description

Following conversation on PR #4894, any method using weight parameter should describe the following

Weight should be non-negative values because the Hessian value multiplied by weight is supposed to be non-negative.

@jameslamb
Copy link
Collaborator

Thanks for writing this up @TremaMiguel . In the future, when referencing a particular comment thread please provide a link directly to it: #4894 (comment). There are many resolved conversations on #4894 and it might be difficult to figure out which conversation on that PR this issue's description refers to.

Are you interested in opening a pull request with this addition to the documentation?

@StrikerRUS
Copy link
Collaborator

@jameslamb

Are you interested in opening a pull request with this addition to the documentation?

I believe answer is

yes, once this PR is done.
#4894 (comment)

@akshitadixit
Copy link
Contributor

Hi is this issue available to work on?

@jameslamb
Copy link
Collaborator

thanks for the interest @akshitadixit ! But based on the comment above, I think @TremaMiguel wanted to do this.

@akshitadixit
Copy link
Contributor

Okay no worries

@TremaMiguel
Copy link
Contributor Author

Ok @jameslamb I'll start working on this. Thanks for the reminder.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants