-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python wheels not PEP 599 compliant; wheels should include libgomp.so.1 #4484
Comments
Thank you very much for this excellent report @AWSjswinney ! Are you interested in contributing this feature? If not, would it be alright for maintainers to |
Yes, I will definitely be happy to answer any questions from maintainers. Also, if I find the the time, I may test and submit a pull request myself. |
Thanks very much! |
If I remember correctly, we are not including OpenMP libraries in wheels intendedly to avoid the following error:
Related: dmlc/xgboost#1715 and apache/mxnet#20095 (comment). Instead, we are asking to install OpenMP system-widely. But we do it only for macOS. I think we can do the same for Linux. Speaking about |
I opened a pull request to update the documentation to mention this. Does this seem like an acceptable compromise? |
Description
PEP 599 and PEP 513 describe a spec for broadly compatible wheels. They include a list of dynamic libraries that wheels are allowed to dynamically link against without bundling the
so
in the wheel. The LightGBM wheel depends onlibgomp.so.1
but does not include in the wheel package. To fix this, you can use auditwheel. I have not tested this, but it probably involves adding line like this, here.Specs:
PEP 599 -- The manylinux2014 Platform Tag
PEP 513 -- A Platform Tag for Portable Linux Built Distributions
Reproducible example
This works on Linux on
x86_64
andaarch64
.docker run -it --rm amazonlinux sh -c "yum install -y python3-pip && pip3 install lightgbm && python3 -c 'import lightgbm'"
Environment info
LightGBM version or commit hash: lightgbm-3.2.1
Command(s) you used to install LightGBM
The text was updated successfully, but these errors were encountered: