Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Add Returns section to docstrings of fit() methods of Dask estimators #4402

Closed
StrikerRUS opened this issue Jun 23, 2021 · 0 comments · Fixed by #4716
Closed

[python] Add Returns section to docstrings of fit() methods of Dask estimators #4402

StrikerRUS opened this issue Jun 23, 2021 · 0 comments · Fixed by #4716
Assignees
@jameslamb
Labels
dask feature request

Comments

@StrikerRUS
Copy link
Collaborator

Refer to #4101 (comment).

Also, during rendering and checking my current suggestions I noticed that there are no Returns sections for fit() methods of Dask estimators. Is it OK?

I guess they should have a return block similar to those in the equivalent scikit-learn estimators ...
@StrikerRUS StrikerRUS mentioned this issue Jun 23, 2021
Merged
jameslamb added a commit that referenced this issue Oct 26, 2021
@jameslamb
[docs] [dask] Add return information to Dask fit() docs (fixes #4402)
96fa1f5
@jameslamb jameslamb mentioned this issue Oct 26, 2021
Merged
@jameslamb jameslamb changed the title Add Returns section to docstrings of fit() methods of Dask estimators [python] Add Returns section to docstrings of fit() methods of Dask estimators Oct 26, 2021
@jameslamb jameslamb self-assigned this Oct 26, 2021
jameslamb added a commit that referenced this issue Nov 8, 2021
@jameslamb
[docs] [dask] Add return information to Dask fit() docs (fixes #4402) (…
858cc0a 
…#4716)

* [docs] [dask] Add return information to Dask fit() docs (fixes #4402)

* put return before note
@StrikerRUS StrikerRUS mentioned this issue Jan 6, 2022
Closed
13 tasks
@jameslamb jameslamb mentioned this issue Oct 7, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameslamb jameslamb

Labels
dask feature request
Projects
None yet
Milestone
No milestone
2 participants
@jameslamb @StrikerRUS