Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default arguments differ between interfaces #4196

Closed
david-cortes opened this issue Apr 18, 2021 · 3 comments · Fixed by #4197
Closed

Default arguments differ between interfaces #4196

david-cortes opened this issue Apr 18, 2021 · 3 comments · Fixed by #4197

Comments

@david-cortes
Copy link
Contributor

In the Python version of lightgbm, the default number of boosting rounds is 100 (which is reasonable), whereas in the R version the default is 10 (which is not reasonable).

Would be nice if both could have the same default arguments.

(I haven't checked the rest of the arguments so I don't know if there are more discrepancies)

@jameslamb
Copy link
Collaborator

Thank you for your interest in LightGBM! As you write comments in this project, please keep your tone and wordings respectful. For example, please avoid referring to characteristics of the code that you disagree with as "not reasonable".

I would support a pull request to change the default value for nrounds to 100 in the R package, since that is the default in LightGBM's core library: https://lightgbm.readthedocs.io/en/latest/Parameters.html#num_iterations. And we'd be grateful for pull requests making similar changes for any other places where you see that the R package's defaults differ from the LightGBM core library defaults documented at https://lightgbm.readthedocs.io/en/latest/Parameters.html.

Are you interested in making such contributions?

@david-cortes
Copy link
Contributor Author

Created ar PR.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants