-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows in CUDA version #3837
Comments
Closed in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature. |
@shiyu1994 |
@StrikerRUS Thanks for proposing this, and thanks for the investigation! Definitely, we have plan for CUDA version on Windows, but not necessarily in 4.0.0. If the changes for windows require only minor revision, we may try to include it in 4.0.0. I think by now we'd better focus on make the new CUDA version stable on Linux. And then we can head for Windows. WDYT? |
@shiyu1994 Yeah, totally fine! I just wanted to hear your opinion on this issue and further plans. Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, this was locked accidentally. Just unlocked it. We'd still love help with this feature! |
Right now CUDA version can be built only on Linux. The main blocker of making CUDA working on Windows is
Source code references:
LightGBM/src/treelearner/cuda_tree_learner.h
Line 243 in a15a370
LightGBM/src/treelearner/cuda_tree_learner.cpp
Lines 207 to 218 in 045ffd9
LightGBM/src/treelearner/cuda_tree_learner.cpp
Lines 490 to 494 in e31244c
Code blocks listed above should be rewritten in a cross-platform manner.
Or if it is impossible, pthread's port for Windows can be properly added in source files tree to make code above works with Visual Studio. For example,
The text was updated successfully, but these errors were encountered: