Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake Deprecation Warning | GoogleTest #952

Closed
ghost opened this issue Nov 15, 2020 · 2 comments · Fixed by #965
Closed

Cmake Deprecation Warning | GoogleTest #952

ghost opened this issue Nov 15, 2020 · 2 comments · Fixed by #965

Comments

@ghost
Copy link

ghost commented Nov 15, 2020

I'm currently using cmake 3.19 and am getting these deprecation warnings when configured GSL as a standalone project.

CMake Deprecation Warning at build/tests/googletest-src/googletest/CMakeLists.txt:56 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Is there any plan to do something about this?

@JordanMaples
Copy link
Contributor

There's currently an issue, google/googletest#3040, and a PR, google/googletest#3094, that would clear this up. Once it's merged, I will update the GoogleTest version.

@JordanMaples
Copy link
Contributor

Looks like they merged 3094, so I'll start updating GoogleTest on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant