Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: Add Schema export and compare APIs #22733

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Oct 4, 2024

Description

See changeset for details.

A realistic detailed usage example can be found in https://github.com/microsoft/FluidFramework/pull/22566/files#diff-b893cfcd2daa74fb9dd1a8b2ce47006faaaefcb7b83671f1413f63faf65257af showing how an actual app may use these APIs. Assuming this lands before the next release, the changeset could get a proper link to that code on main added as an example.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested review from a team as code owners October 4, 2024 21:53
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Stats:
  427184 links
    3302 destination URLs
       2 URLs ignored
       0 warnings
       0 errors


@CraigMacomber CraigMacomber enabled auto-merge (squash) October 4, 2024 23:20
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +317 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.47 KB 460.5 KB +35 Bytes
azureClient.js 557.45 KB 557.5 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.74 KB 259.76 KB +14 Bytes
fluidFramework.js 405.91 KB 405.96 KB +50 Bytes
loader.js 134.34 KB 134.36 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.63 KB 148.64 KB +7 Bytes
odspClient.js 524.41 KB 524.46 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.82 KB 164.83 KB +7 Bytes
sharedTree.js 396.37 KB 396.41 KB +43 Bytes
Total Size 3.31 MB 3.31 MB +317 Bytes

Baseline commit: 014d670

Generated by 🚫 dangerJS against f47641c

@CraigMacomber CraigMacomber merged commit 920a65f into microsoft:main Oct 4, 2024
33 checks passed
@CraigMacomber CraigMacomber deleted the schemaExport branch October 5, 2024 00:19
sonalideshpandemsft pushed a commit that referenced this pull request Oct 7, 2024
## Description

See changeset for details.

A realistic detailed usage example can be found in
https://github.com/microsoft/FluidFramework/pull/22566/files#diff-b893cfcd2daa74fb9dd1a8b2ce47006faaaefcb7b83671f1413f63faf65257af
showing how an actual app may use these APIs. Assuming this lands before
the next release, the changeset could get a proper link to that code on
main added as an example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants