-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(devtools): Mark interfaces as @sealed
and @system
as appropriate
#23165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- packages/tools/devtools/devtools-core/api-report/devtools-core.alpha.api.md: Evaluated as low risk
- packages/tools/devtools/devtools-core/api-report/devtools-core.beta.api.md: Evaluated as low risk
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 645a1a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good pending one minor comment!
Co-authored-by: jzaffiro <[email protected]>
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
APIs that were never intended for direct consumer use have been marked as
@system
.These are:
And APIs that were not intended to be extended by consumers have been marked as
@sealed
.These are:
Additionally, interface properties have been marked as
readonly
.Note that all of the affected APIs are
@beta
, so this change is not in violation of our breaking changes policy.And in practice, it is unlikely to affect any users of our APIs.