-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clone to SharedTree Revertible #23044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↓ packages.dds.tree.src.shared-tree:
Line Coverage Change: -0.02% Branch Coverage Change: -0.17%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 91.76% | 91.59% | ↓ -0.17% |
Line Coverage | 97.30% | 97.28% | ↓ -0.02% |
↑ packages.dds.tree.src.simple-tree.api:
Line Coverage Change: 0.02% Branch Coverage Change: No change
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 89.77% | 89.77% | → No change |
Line Coverage | 82.34% | 82.36% | ↑ 0.02% |
Baseline commit: d3bf90c
Baseline build: 308876
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +919 Bytes
Baseline commit: 224f59a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- packages/dds/tree/src/core/index.ts: Evaluated as low risk
Comments skipped due to low confidence (2)
packages/dds/tree/src/shared-tree/treeCheckout.ts:634
- [nitpick] The method name 'clone' might be ambiguous. Consider renaming it to 'createClone' or 'duplicate' for better clarity.
clone: (forkedBranch?: TreeBranch) => {
packages/dds/tree/src/shared-tree/treeCheckout.ts:639
- [nitpick] The error message 'Unable to dispose a revertible that has already been disposed.' could be more descriptive. Consider providing more context about why this error might occur.
throw new UsageError("Unable to dispose a revertible that has already been disposed.");
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks correct. You'll need to a changeset and get docs review before checking in.
Co-authored-by: jzaffiro <[email protected]>
Co-authored-by: jzaffiro <[email protected]>
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for docs pending one minor comment
Description
13864
This PR adds forkable revertible feature to the
Revertible
object of SharedTree.DisposableRevertible
and replaced byRevertibleAlpha
.clone()
method to the new interface.TreeBranch
(which is subset ofTreeCheckout
) to access data necessary for revert operation.