fix(client-presence): ISessionClient naming consistency #22973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and misc cleanup. Overall SessionClient class is introduced with updated ISessionClient API, but functionality is not changed.
github-actions
bot
added
area: examples
Josmithr
reviewed
Nov 4, 2024
jason-ha
requested review from
tylerbutler,
ChumpChief,
pk-pranshu,
kashms,
WillieHabi and
a team
Josmithr
reviewed
Nov 4, 2024
Josmithr
approved these changes
Nov 4, 2024
jason-ha
added
the
release-blocking
|
Replaces #22889 |
tylerbutler
approved these changes
Nov 4, 2024
|
|
||
| public setConnectionId( | ||
| connectionId: ClientConnectionId, | ||
| updateStatus: boolean = true, |
There was a problem hiding this comment.
When might you set updateStatus to false?
There was a problem hiding this comment.
We think the management of connectivity is funky at the moment. I expect this will change when Task 22616: "Address ISessionClient connectivity consistency" is done. I hope this parameter just goes away. We'll see. I am using it now to preserve the logic as-is.
Co-authored-by: Tyler Butler <[email protected]>
I thought I got all in the files that were already touched and anything public facing. |
msfluid-bot
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Code Coverage Summary
↑ packages.framework.presence.src:
Line Coverage Change: 0.21% Branch Coverage Change: 0.18%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 83.87% | 84.05% | ↑ 0.18% |
| Line Coverage | 61.93% | 62.14% | ↑ 0.21% |
Baseline commit: 80ed028
Baseline build: 304016
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 80ed028 |
Josmithr
pushed a commit
that referenced
this pull request
Nov 5, 2024
1. `ISessionClient` method names updated for consistency to `getConnectionId()` and `getConnectionStatus()`. 2. Implementation of `ISessionClient` moved to a full class object. 3. Changeset provided for Presence changes since 2.4. 4. Updated `id` to `ID` in comments (public and most internal). No behavior is changed. [AB#21446](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/21446) --------- Co-authored-by: Willie Habimana <[email protected]> Co-authored-by: Tyler Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISessionClientmethod names updated for consistency togetConnectionId()andgetConnectionStatus().ISessionClientmoved to a full class object.idtoIDin comments (public and most internal).No behavior is changed.
AB#21446