fix: Update DCR creation to Clusters resource group instead of workspace (ARM Template update) #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace (ARM Template update)
ganga1980
reviewed
Sep 8, 2022
scripts/onboarding/aks/onboarding-using-msi-auth/existingClusterOnboarding.json
Show resolved
Hide resolved
ganga1980
reviewed
Sep 8, 2022
scripts/onboarding/aks/onboarding-using-msi-auth/existingClusterOnboarding.json
Outdated
Show resolved
Hide resolved
ganga1980
reviewed
Sep 8, 2022
scripts/onboarding/aks/onboarding-using-msi-auth/existingClusterOnboarding.json
Outdated
Show resolved
Hide resolved
ganga1980
reviewed
Sep 8, 2022
| @@ -20,12 +20,6 @@ | |||
| "description": "Azure Monitor Log Analytics Resource ID" | |||
| } | |||
| }, | |||
| "workspaceRegion": { | |||
There was a problem hiding this comment.
Please note that, MSI auth support exists in k8s-extension of the azure-cli extensions so which needs to be updated as well.
There was a problem hiding this comment.
Will sync on this, with you.
There was a problem hiding this comment.
created draft PR with the change here -> AzureArcForKubernetes/azure-cli-extensions#175
|
Making this PR against ci_prod as we've switched to using one branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to CLI PR: Azure/azure-cli#23630.
Deepanshu is updating this in the UX with the prometheus update