Enable searching. #136
Merged
Enable searching. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
requested review from
manodasanW,
huzaifa-d,
vineeththomasalex,
dkbennett,
krschau,
EricJohnson327,
sshilov7,
AmelBawa-msft,
bbonaby,
ssparach and
a team
sshilov7
reviewed
Mar 9, 2024
sshilov7
reviewed
Mar 9, 2024
bbonaby
reviewed
Mar 14, 2024
bbonaby
approved these changes
Mar 14, 2024
kanismohammed
approved these changes
Mar 18, 2024
dhoehna
merged commit f595569
into
feature/dhoehna/SearchOptionsForGettingRepositories
1 of 3 checks passed
jsidewhite
reviewed
Mar 18, 2024
| } | ||
|
|
||
| return _organizationsAndProjects[organization]; | ||
| } |
There was a problem hiding this comment.
I don't understand this locking code - is it right?
I see only one lock on '_getProjectsLock' but many users of '_organizationsAndProjects'.
And there's a double-checked lock - which is always super fishy (at least if the caller requires the returned information to be correct.)
jsidewhite
reviewed
Mar 18, 2024
| } | ||
| if (developerId is not DeveloperId.DeveloperId azureDeveloperId) | ||
| { | ||
| var exception = new NotSupportedException("Authenticated user is not the an azure developer id."); |
jsidewhite
reviewed
Mar 18, 2024
| } | ||
| if (defaultOrg != null) | ||
| { | ||
| server = _defaultSearchServerName; |
jsidewhite
reviewed
Mar 18, 2024
|
|
||
| _azureHierarchy ??= new AzureRepositoryHierarchy(azureDeveloperId); | ||
| _azureHierarchy ??= new AzureRepositoryHierarchy(azureDeveloperId); |
There was a problem hiding this comment.
_azureHierarchy ??= new AzureRepositoryHierarchy(azureDeveloperId);
(i'm new to c# and ??= and Task.Run - so forgive my questions)
How does _azureHierarchy stay correct.
Say someone calls GetRepos with azureDeveloperId X, and that sets _azureHierarchy. Then someone calls GetRepositoriesAsync with azureDeveloperId Y.
Who is GetOrganizations [on line 171] being called for - user X or user Y?
There was a problem hiding this comment.
Hrm - I think i just don't understand line 162
developerId is not DeveloperId.DeveloperId azureDeveloperId
dhoehna
added a commit
that referenced
this pull request
Mar 21, 2024
* Adding search functionality to repos (#117) * Building with new SDK. Have not tested * WIP * Handling the new SDK + .NET 8.0 * Adding comments * Fixing some errors * Using updated SDK * Update src/AzureExtension/Providers/RepositoryProvider.cs Co-authored-by: Branden Bonaby <[email protected]> * Update src/AzureExtension/Providers/RepositoryProvider.cs Co-authored-by: Branden Bonaby <[email protected]> * Reverting .NET 8 changes * Slipped through * Removing IRepositoryProvider since IRepositoryProvider2 requires it. * Using lock * USing locks instead of tasks * Moving return to inside the lock. * typo --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Branden Bonaby <[email protected]> * Enable searching. (#136) * Eeeyyy, it works. :) * Removing local source * Adding comments to explain the server search code. * Addressing comments. * Update src/AzureExtension/Strings/en-US/Resources.resw Co-authored-by: Branden Bonaby <[email protected]> * Moving reading code outside of the lock. * Adding some race-condition checking --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Branden Bonaby <[email protected]> * Change * Updating to new SDK * Removing local package source --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Branden Bonaby <[email protected]>
huzaifa-d
pushed a commit
that referenced
this pull request
Apr 1, 2024
* Adding search functionality to repos (#117) * Building with new SDK. Have not tested * WIP * Handling the new SDK + .NET 8.0 * Adding comments * Fixing some errors * Using updated SDK * Update src/AzureExtension/Providers/RepositoryProvider.cs Co-authored-by: Branden Bonaby <[email protected]> * Update src/AzureExtension/Providers/RepositoryProvider.cs Co-authored-by: Branden Bonaby <[email protected]> * Reverting .NET 8 changes * Slipped through * Removing IRepositoryProvider since IRepositoryProvider2 requires it. * Using lock * USing locks instead of tasks * Moving return to inside the lock. * typo --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Branden Bonaby <[email protected]> * Enable searching. (#136) * Eeeyyy, it works. :) * Removing local source * Adding comments to explain the server search code. * Addressing comments. * Update src/AzureExtension/Strings/en-US/Resources.resw Co-authored-by: Branden Bonaby <[email protected]> * Moving reading code outside of the lock. * Adding some race-condition checking --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Branden Bonaby <[email protected]> * Change * Updating to new SDK * Removing local package source --------- Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Branden Bonaby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Enables searching for repos.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Manually ran and validated I could clone repos.
PR checklist