-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to restore or replace cimetrics #6126
Comments
I looks like bencher.dev may be what we want. Test job: https://github.com/microsoft/CCF/blob/bencher_experiment/.github/workflows/bencher.yml, works on ubuntu 20.04 using a 1ES pool. The json adapter supports both latency and throughput, and the format is very simple: https://bencher.dev/docs/explanation/adapters/#-json I think we would move the performance tests to GHA for simplicity, and we would start with just running on main. The setup for PRs on branches seems to need a bit of care to avoid exposing secrets, but we may be able to do without it and just check periodically. |
|
Everything has been moved over now. I think there are probably two last things to explore before closing this task:
Proposed renames:
|
After review with @eddyashton, we want in addition:
|
Fiddling locally, I'm seeing ~56k with the current |
@eddyashton agreed, that'd be useful for clarity, especially since further changes are coming for programmability. It's going to increase build times though, so I think we may want to find something we can sacrifice too. |
We disabled
cimetrics
in #6125, to avoid use ofMETRICS_MONGO_CONNECTION
.We should look at restoring
cimetrics
, either with improved auth to mongo, or by finding an alternative storage mechanism.The text was updated successfully, but these errors were encountered: