Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bundling] No .cjs under /lib/ #5175

Closed
compulim opened this issue May 8, 2024 · 0 comments · Fixed by #5181 · 4 remaining pull requests
Closed

[Bundling] No .cjs under /lib/ #5175

compulim opened this issue May 8, 2024 · 0 comments · Fixed by #5181 · 4 remaining pull requests
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@compulim
Copy link
Contributor

compulim commented May 8, 2024

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

NPM

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

Others or unrelated

Which area does this issue affect?

Development experience

Which theme pack does this issue affect?

I did not test it on other theme packs

What is the public URL for the website?

No response

Please describe the bug

botframework-webchat-api should not publish /lib/external/PrecompiledGlobalize.cjs, instead, it should be .js.

image

Do you see any errors in console log?

Webpack 4 may not recognize `.cjs` and throw an error.

How to reproduce the issue?

  1. Build Web Chat using a vanilla Webpack 4 configuration

What do you expect?

Build should success.

What actually happened?

Build failed.

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

To workaround, add .cjs to resolve.extensions.

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels May 8, 2024
This was referenced Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment