Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after telemetry event "send-status:change" #4638

Open
compulim opened this issue Feb 13, 2023 · 0 comments
Open

Clean up after telemetry event "send-status:change" #4638

compulim opened this issue Feb 13, 2023 · 0 comments

Comments

@compulim
Copy link
Contributor

compulim commented Feb 13, 2023

Is your feature request related to a problem?

After PR #4631 is merged, we have pending clean up things to do.

Describe the suggestion or request in detail

Exporting send-status:change typing

Export this typing out. Need some designs because currently, we don't export any telemetry typings.

type TelemetrySendStatusChangePayload = {
  clientActivityID?: string;
  hasAttachment?: 'true' | 'false';
  key: string;
  prevStatus?: 'sending' | 'send failed' | 'sent';
  status: 'sending' | 'send failed' | 'sent';
  type?: string;
};

Clean up TELEMETRY.md

Add a section to elaborate about the new send-status:change event.

Describe alternatives you have considered

No response

Additional context

Related to #4500 and #4631.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant