Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowlist only aria-label attributes set in Markdown #4094

Closed
compulim opened this issue Dec 14, 2021 · 0 comments · Fixed by #4095
Closed

Allowlist only aria-label attributes set in Markdown #4094

compulim opened this issue Dec 14, 2021 · 0 comments · Fixed by #4095
Labels
feature-request Azure report label

Comments

@compulim
Copy link
Contributor

compulim commented Dec 14, 2021 •
edited
Loading

Feature Request

Our sanitize HTML rules only allows aria-label to be set.

  allowedAttributes: {
    a: ['aria-label', 'href', 'name', 'rel', 'target', 'title'],
    img: ['alt', 'class', 'src']
  },

We should allowlist aria-label when using the markdown-it-attrs plug-in.

[feature-request]
@compulim compulim added the feature-request Azure report label label Dec 14, 2021
@compulim compulim mentioned this issue Dec 14, 2021
Merged
11 tasks
@compulim compulim changed the title Whitelist only aria-label attributes set in Markdown Allowlist only aria-label attributes set in Markdown Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Azure report label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Markdown: whitelist aria-label for curly brackets compulim/BotFramework-WebChat
1 participant
@compulim