Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard Navigation - Bot Webchat - Suggested actions ]: Keyboard focus indicator is not clearly visible on card control. #4029

Closed
KattaBhargav opened this issue Aug 16, 2021 · 7 comments · Fixed by #4035
Assignees
Labels
Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 area-accessibility bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport exempt from daily DRI report
Milestone

Comments

@KattaBhargav
Copy link

KattaBhargav commented Aug 16, 2021

User Experience:
If focus indicator is not clearly visible on card controls, then users with motor disabilities who depend on keyboard for navigation will not be able to identify the focus on that control which can prevent them from performing actions which are important.

Repro Steps:

  1. Open URL: Web Chat: Full-featured bundle (microsoft.github.io)
  2. Web chat bundle will open.
  3. Navigate on the web chat bot and enter "suggested-actions’" keyword in Type your message box, then select send button.
  4. Cards related to the keyword will appear, navigate on the cards.
  5. Check and verify that step 3-4 are accessible and MAS compliant.

Actual Result:
Keyboard focus indicator is not clearly visible on card control.

Expected Result:
Keyboard focus indicator should be clearly visible on card control.

MAS Reference:
WCAG2.4.7 – Focus Visible

Test Environment:
OS: Win 10 21H1
Build: OS Build 19043.1147
Browser: Edge Chromium Version 94.0.972.2 (Official build) dev (64-bit)
#URL: Web Chat: Full-featured bundle (microsoft.github.io)

@KattaBhargav KattaBhargav added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Aug 16, 2021
@KattaBhargav
Copy link
Author

KattaBhargav commented Aug 16, 2021

#A11yMAS;#A11ySev2;#HCL;#WCAG2.4.7;#Accessibility;#Win10-Edge(Chromium);#BotFrameworkWebChat-Aug21;#Closed;#Regression;

@joshgummersall joshgummersall removed customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Aug 16, 2021
@compulim compulim removed their assignment Aug 16, 2021
@joshgummersall joshgummersall added the ExemptFromDailyDRIReport exempt from daily DRI report label Aug 17, 2021
@compulim compulim added this to the R15 milestone Aug 23, 2021
@compulim
Copy link
Contributor

compulim commented Sep 2, 2021

We will update our style to align with Fluent UI Default Button. Particularly:

  • Single pixel border (currently, it is double pixel border)
  • Very slight roundness (possibly, 1px roundness)
  • Double border when :focus-visible (focus by keyboard)
  • Light-dim on mouse hover
  • Dim on click via keyboard or mouse

@compulim compulim self-assigned this Sep 13, 2021
@compulim
Copy link
Contributor

compulim commented Sep 14, 2021

Copying styles from Fluent UI.

image

This is the style for the button.

image

This is the additional style when :focus-visible is applied to the button.

image

When hover.

image

When active.

image

Note: inset style does not works on IE11.

@compulim
Copy link
Contributor

I am keeping this open but resolved.

@compulim compulim reopened this Sep 22, 2021
@compulim compulim added the Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 label Sep 27, 2021
@compulim
Copy link
Contributor

compulim commented Sep 27, 2021

Status: Fixed

The issue is fixed in #4035.

Here is a quick recap of how it works.

recording (28)

@v-shikch
Copy link

As verified issue on URL: Web Chat: Full-featured bundle (microsoft.github.io) on Browser: Edge Chromium Version 96.0.1028.0 (Official build) dev (64-bit), here issue is fixed. Hence closing the bug.

@compulim
Copy link
Contributor

Thanks @v-shikch and @KattaBhargav. Appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility: Audit 2021-08-21 Issues that discovered during audit on 2021-08-21 area-accessibility bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport exempt from daily DRI report
Projects
None yet
4 participants