Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in Azure chat bot adaptive cards given aria-label="undefined" #3591

Closed
Amit8527510735 opened this issue Nov 5, 2020 · 5 comments
Closed
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@Amit8527510735
Copy link

Amit8527510735 commented Nov 5, 2020

Accessibility 161215: Links in Azure chat bot adaptive cards given aria-label="undefined"

Product name, version, and build: Azure Chat Bot, Edge/Chrome v.86

OS version and build: Windows 10

AT version and build (if applicable): JAWS 2020, NVDA 2020.3

Does this repro with other AT? (If applicable) Yes, Narrator and NVDA

Share access to the environment (if applicable):

Prerequisite (if any)

Description
When accessing the customer's chat experience, some of the adaptive cards are given a URL. When navigating to that URL with a screen reader, the label is "undefined"

Repro steps

  1. Open URL to environment in Chrome/edge
  2. Open JAWS or NVDA
  3. in ZIP code edit field, type 97478 and press Enter
  4. Tab to service and select "additional services"
  5. Tab to "go to facility detail" link

Screenshots N/A

Actual results
When the screen reader lands on the link, the label is read as Undefined.

12. Expected Results
When the AT lands on the link, it should read 'go to facility detail page'

WCAG Reference Link:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

Source Code:

@Amit8527510735
Copy link
Author

Amit8527510735 commented Nov 5, 2020

#Accessibility;#WCAG1.3.1;#HCL;;#HCL_BotFramework_WebChat;#A11yMAS;

@compulim
Copy link
Contributor

compulim commented Nov 5, 2020

Looks like they fixed in recent versions of Adaptive Cards.

I copied the AC JSON from the page and pasted to AC designer tool and the DOM tree looks good.

image

This will be fixed once we bump AC in issue #3392.

{
  "type": "AdaptiveCard",
  "version": "1.2",
  "body": [
    {
      "type": "ColumnSet",
      "columns": [
        {
          "type": "Column",
          "width": "290px",
          "items": [
            {
              "type": "Container",
              "items": [
                {
                  "type": "ColumnSet",
                  "columns": [
                    {
                      "type": "Column",
                      "width": "auto",
                      "items": [
                        {
                          "type": "Image",
                          "size": "small",
                          "style": "person",
                          "url": "data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHN2ZyB3aWR0aD0iMTRweCIgaGVpZ2h0PSIyMHB4IiB2aWV3Qm94PSIwIDAgMTQgMjAiIHZlcnNpb249IjEuMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+CiAgICA8dGl0bGU+MzIwL0VsZW1lbnQvSWNvbiAtIExvY2F0aW9uIENvcHk8L3RpdGxlPgogICAgPGcgaWQ9IjA0Li1XaXJlZnJhbWVzIiBzdHJva2U9Im5vbmUiIHN0cm9rZS13aWR0aD0iMSIgZmlsbD0ibm9uZSIgZmlsbC1ydWxlPSJldmVub2RkIj4KICAgICAgICA8ZyBpZD0iUGhhcm1hY2llcy1GYWNpbGl0eS1EZXRhaWwiIHRyYW5zZm9ybT0idHJhbnNsYXRlKC01OC4wMDAwMDAsIC00MDcuMDAwMDAwKSIgZmlsbD0iIzAwM0I3MSIgZmlsbC1ydWxlPSJub256ZXJvIj4KICAgICAgICAgICAgPGcgaWQ9IjMyMC9FbGVtZW50L0ljb24tLS1Mb2NhdGlvbiIgdHJhbnNmb3JtPSJ0cmFuc2xhdGUoNDUuMDAwMDAwLCAzOTcuMDAwMDAwKSI+CiAgICAgICAgICAgICAgICA8cGF0aCBkPSJNMjYuOTksMTYuNzEgQzI2LjgzNDc5MjksMTIuOTY3NTU2IDIzLjc1NTY2MSwxMC4wMTM0NzU0IDIwLjAxLDEwLjAxMzQ3NTQgQzE2LjI2NDMzOSwxMC4wMTM0NzU0IDEzLjE4NTIwNzEsMTIuOTY3NTU2IDEzLjAzLDE2LjcxIEMxMy4wMTMzOTU0LDE2LjgwNTcyMzcgMTMuMDA2NjkzNCwxNi45MDI5MDMxIDEzLjAxLDE3IEwxMy4wMSwxNy4wNyBDMTMuMDAxMDQzMSwxNy43MDE1NTM0IDEzLjA4MTg1MDQsMTguMzMxMTc2OSAxMy4yNSwxOC45NCBDMTMuNjA2NjY5NywyMC4xNTIzOTkxIDE0LjA3ODgzMjcsMjEuMzI3NzgzNiAxNC42NiwyMi40NSBDMTUuNDQ3NDE1MywyMy45OTc2NTA3IDE2LjMxNTI2ODIsMjUuNTAzMDQxOCAxNy4yNiwyNi45NiBMMTcuNjQsMjcuNTcgQzE3Ljg1LDI3LjkgMTguMDcsMjguMjQgMTguMywyOC41OCBMMTguNjksMjkuMTkgQzE4Ljk2Nzc4NDIsMjkuNjU4MTI0OSAxOS40NTcwODM3LDI5Ljk2MDY2ODkgMjAsMzAgTDIwLjAyLDMwIEMyMC41NjI5MTYzLDI5Ljk2MDY2ODkgMjEuMDUyMjE1OCwyOS42NTgxMjQ5IDIxLjMzLDI5LjE5IEwyMS43MiwyOC41OCBDMjEuOTUsMjguMjQgMjIuMTcsMjcuOSAyMi4zOCwyNy41NyBMMjIuNzYsMjYuOTYgQzIzLjcwNDczMDIsMjUuNTAzMDQwOCAyNC41NzI1ODMxLDIzLjk5NzY0OTggMjUuMzYsMjIuNDUgQzI1Ljk0MTE2NzMsMjEuMzI3NzgzNiAyNi40MTMzMzAzLDIwLjE1MjM5OTEgMjYuNzcsMTguOTQgQzI2LjkzODE0OTYsMTguMzMxMTc2OSAyNy4wMTg5NTY5LDE3LjcwMTU1MzQgMjcuMDEsMTcuMDcgTDI3LjAxLDE3IEMyNy4wMTMzMDY2LDE2LjkwMjkwMzEgMjcuMDA2NjA0NiwxNi44MDU3MjM3IDI2Ljk5LDE2LjcxIEwyNi45OSwxNi43MSBaIE0yNS4wMSwxNy4wNiBDMjUuMDE3NjE2NywxNy41MTU3ODM1IDI0Ljk2MDM3NywxNy45NzAzMzQyIDI0Ljg0LDE4LjQxIEMyNC41MTU5MjM1LDE5LjUwMDU1ODggMjQuMDkwNzQ1NCwyMC41NTg0ODIyIDIzLjU3LDIxLjU3IEMyMy4yMiwyMi4yNyAyMi44OCwyMi45IDIyLjUsMjMuNTQgQzIyLjA4LDI0LjI2IDIxLjYyLDI0Ljk5OTk5MDEgMjEuMDYsMjUuOSBMMjAuNjksMjYuNDk5OTkwMSBDMjAuNDgsMjYuODIgMjAuMjYsMjcuMTYgMjAuMDUsMjcuNDk5OTkwMSBMMjAuMDEsMjcuNTUgTDE5Ljk3LDI3LjQ5OTk5MDEgQzE5Ljc2LDI3LjE2IDE5LjU0LDI2LjgyIDE5LjMzLDI2LjQ5OTk5MDEgTDE4Ljk2LDI1LjkgQzE4LjQsMjQuOTk5OTkwMSAxNy45NCwyNC4yNiAxNy41MiwyMy41NCBDMTcuMTQsMjIuOSAxNi44LDIyLjI3IDE2LjQ1LDIxLjU3IEMxNS45MjkyNTk5LDIwLjU1ODQ3OTggMTUuNTA0MDgyLDE5LjUwMDU1NjkgMTUuMTgsMTguNDEgQzE1LjA1OTYzNjMsMTcuOTcwMzMxNSAxNS4wMDIzOTY5LDE3LjUxNTc4MjggMTUuMDEsMTcuMDYgTDE1LjAxLDE2Ljk5OTk5MDEgQzE1LjAwODM0NzYsMTYuOTUzMTEwNSAxNS4wMTE2OTk5LDE2LjkwNjE3ODYgMTUuMDIsMTYuODYgQzE1LjA4MjcwNDIsMTQuNTQyNTExNiAxNi43MzAyMzk1LDEyLjU3MjA5MjUgMTksMTIuMSBDMTkuNjY2NzMxNCwxMS45NjY2NTM1IDIwLjM1MzI2ODYsMTEuOTY2NjUzNSAyMS4wMiwxMi4xIEMyMy4yODk3NjA1LDEyLjU3MjA5MjUgMjQuOTM3Mjk1OCwxNC41NDI1MTE2IDI1LDE2Ljg2IEMyNS4wMDgzMDAxLDE2LjkwNjE3ODYgMjUuMDExNjUyNCwxNi45NTMxMTA1IDI1LjAxLDE2Ljk5OTk5MDEgTDI1LjAxLDE3LjA2IFoiIGlkPSJQYXRoXzgiPjwvcGF0aD4KICAgICAgICAgICAgICAgIDxwYXRoIGQ9Ik0yMC4wMSwyMCBDMjEuNjY2ODU0MiwyMCAyMy4wMSwxOC42NTY4NTQyIDIzLjAxLDE3IEMyMy4wMSwxNS4zNDMxNDU4IDIxLjY2Njg1NDIsMTQgMjAuMDEsMTQgQzE4LjM1MzE0NTgsMTQgMTcuMDEsMTUuMzQzMTQ1OCAxNy4wMSwxNyBDMTcuMDEsMTguNjU2ODU0MiAxOC4zNTMxNDU4LDIwIDIwLjAxLDIwIEwyMC4wMSwyMCBaIiBpZD0iUGF0aF85Ij48L3BhdGg+CiAgICAgICAgICAgIDwvZz4KICAgICAgICA8L2c+CiAgICA8L2c+Cjwvc3ZnPg==",
                          "width": "20px"
                        }
                      ]
                    },
                    {
                      "type": "Column",
                      "width": "stretch",
                      "items": [
                        {
                          "type": "TextBlock",
                          "size": "medium",
                          "weight": "bolder",
                          "text": "**PeaceHealth Sacred Heart Medical Center Riverbend**",
                          "wrap": true
                        },
                        {
                          "type": "RichTextBlock",
                          "inlines": [
                            {
                              "type": "TextRun",
                              "text": "Affiliate"
                            }
                          ]
                        },
                        {
                          "type": "TextBlock",
                          "text": "10.9 miles",
                          "wrap": true
                        },
                        {
                          "type": "TextBlock",
                          "text": "541-222-7300",
                          "wrap": true
                        },
                        {
                          "type": "TextBlock",
                          "weight": "bolder",
                          "text": "**Facility Type:**",
                          "wrap": true
                        },
                        {
                          "type": "TextBlock",
                          "text": "Hospital",
                          "wrap": true
                        },
                        {
                          "type": "TextBlock",
                          "weight": "bolder",
                          "text": "**Address:**",
                          "wrap": true
                        },
                        {
                          "type": "TextBlock",
                          "text": " 3333 Riverbend Dr, Springfield, OR 97477",
                          "wrap": true
                        },
                        {
                          "type": "TextBlock",
                          "weight": "bolder",
                          "text": "**Facility Hours:**",
                          "wrap": true
                        },
                        {
                          "type": "TextBlock",
                          "text": "Hours Unavailable",
                          "wrap": true
                        },
                        {
                          "type": "Container",
                          "items": [
                            {
                              "type": "TextBlock",
                              "color": "attention",
                              "text": "Go to facility detail page"
                            }
                          ],
                          "selectAction": {
                            "type": "Action.OpenUrl",
                            "url": "https://example.com/oregon-washington/facilities/PeaceHealth-Sacred-Heart-Medical-Center-Riverbend-335481"
                          }
                        }
                      ]
                    }
                  ]
                }
              ]
            }
          ]
        }
      ]
    }
  ],
  "trigger": "facilityDetailsTrigger"
}

@cwhitten cwhitten changed the title Kaiser Permanente: Links in Azure chat bot adaptive cards given aria-label="undefined" Links in Azure chat bot adaptive cards given aria-label="undefined" Nov 6, 2020
@CezaryMarcjan CezaryMarcjan added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Nov 6, 2020
@compulim compulim removed their assignment Nov 6, 2020
@compulim
Copy link
Contributor

compulim commented Nov 6, 2020

Investigations completed, unassigning myself.

@corinagum
Copy link
Contributor

Closing this issue. Please keep an eye on #3392 for updates.

@cwhitten cwhitten added the customer-replied-to Required for internal reporting. Do not delete. label Nov 9, 2020
@kattepalli
Copy link

#A11ySev2;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

No branches or pull requests

6 participants