Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if timestamp of 48+ hours will throw error on render #3279

Closed
1 task done
compulim opened this issue Jun 24, 2020 · 0 comments · Fixed by #3282 or #3304
Closed
1 task done

Investigate if timestamp of 48+ hours will throw error on render #3279

compulim opened this issue Jun 24, 2020 · 0 comments · Fixed by #3282 or #3304
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. external-omnichannel

Comments

@compulim
Copy link
Contributor

compulim commented Jun 24, 2020

Background

Charlie reported the timestamp will throw error on render.

Action items

  • Repro the issue

Investigation notes

Seems introduced in Web Chat 4.8.1 in PR #3095.

The reason why the "day before yesterday" is not working: the code is using "en-US" for date formatting. But it's not there (Unicode has no "en-US", but "en").

Need more investgation because:

  • "en-US" is not in locale database and it is correct, it should be "en" instead
    • Did we or should we normalize "en-US" to "en"?
  • When a locale is not found, there should be a fallback mechanism and not error out
  • Someone using "xx-ZZ" locale should fallback to "en"

[Bug]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. external-omnichannel
Projects
None yet
1 participant