Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Use <ScreenReaderText> in favor of aria-label #3096

Closed
compulim opened this issue Apr 9, 2020 · 0 comments · Fixed by #3097
Closed

Accessibility: Use <ScreenReaderText> in favor of aria-label #3096

compulim opened this issue Apr 9, 2020 · 0 comments · Fixed by #3097
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Apr 9, 2020

Version

4.8.0

Describe the bug

Support of aria-label in screen reader varies. It seems working when assigning to role="section", but not when role="group".

For texts that are intended for screen reader, we should use <ScreenReaderText> for offscreen rendering, instead of aria-label.

Steps to reproduce

  1. Turn on narrator
  2. Type "card breakfast" to the bot
  3. Press SHIFT + TAB
  4. Press up arrow button few times and listen to the narration

Expected behavior

The narration should be precise without lots of repetitives and without any missing information. It must speak activity text + timestamp.

Additional context

This article outline why offscreen texts are recommended over aria-label.

https://developer.paciellogroup.com/blog/2017/07/short-note-on-aria-label-aria-labelledby-and-aria-describedby/

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. area-accessibility labels Apr 9, 2020
@compulim compulim mentioned this issue Apr 10, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use <ScreenReaderText> in favor of aria-label compulim/BotFramework-WebChat
1 participant
@compulim