Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Cognitive Services SDK to 1.9.1 #2979

Closed
compulim opened this issue Mar 5, 2020 · 0 comments · Fixed by #2980
Closed

Lock Cognitive Services SDK to 1.9.1 #2979

compulim opened this issue Mar 5, 2020 · 0 comments · Fixed by #2980
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Mar 5, 2020

Screenshot

When using Cognitive Services SDK 1.10.0 with Web Chat NPM, we are seeing:

image

image

image

image

Version

master of now.

Describe the bug

When pairing Cognitive Services SDK 1.10.0 with Direct Line Speech SDK, it failed on this line:

class ConversationImpl extends Conversation {
  ...
}

The problem is Conversation is undefined, causing an error "super expression must either be null or a function".

Translate to human:

const Conversation = undefined; // or 123, 'abc', true, {}, []

class ConversationImpl extends Conversation {
   ...
}

Seems related to microsoft/cognitive-services-speech-sdk-js#155.

Steps to reproduce

  1. npm install botframework-directlinespeech on a NPM project
  2. Verify node_modules/microsoft-cognitiveservices-speech-sdk to be 1.9.1

Expected behavior

Direct Line Speech SDK should work with npm install. Instead, it bring down 1.10.0 which is not compatible with Direct Line Speech SDK.

Additional context

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Mar 5, 2020
@compulim compulim changed the title Lock down to Cognitive Services SDK 1.9.1 Lock Cognitive Services SDK to 1.9.1 Mar 5, 2020
@compulim compulim mentioned this issue Mar 5, 2020
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant