Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification toast expander overlapped #2945

Closed
compulim opened this issue Feb 25, 2020 · 0 comments · Fixed by #2952
Closed

Notification toast expander overlapped #2945

compulim opened this issue Feb 25, 2020 · 0 comments · Fixed by #2952
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

Screenshots

image

image

Version

master as of today.

Describe the bug

The notification should have min-height: 32px instead of height: 32px.

Steps to reproduce

  1. Add 2 notifications, with one spanning more than a single line

Expected behavior

Bounding box assigned to the taller toast should have border-bottom rendered properly.

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Feb 25, 2020
@compulim compulim self-assigned this Feb 26, 2020
@compulim compulim mentioned this issue Feb 27, 2020
Merged
1 task
@compulim compulim mentioned this issue Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix overlapping toasts compulim/BotFramework-WebChat
1 participant
@compulim