Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The keyboard opens automatically after clicking on a suggestion action button on Webchat with version 4.7.1 or 4.7.0 or latest #2850

Closed
didaskein opened this issue Jan 23, 2020 · 13 comments · Fixed by #3123
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@didaskein
Copy link

didaskein commented Jan 23, 2020

Issue with webchat version : 4.7.1 or 4.7.0 or latest
On Mobile Anroid (Samsung S9), or Iphone (8)

Sample of the issue (the keyboard open automatically after clicking on a suggestion action button)
Before clicking on the suggest action button "Oui"
image

After clicking on the suggest action button "Oui", we have the keyboard opened.
image

The code we are using in order to send the suggested action
image

When you click on the button, we need to have the value clicked on the right of the transcript of the conversation.
image

The behavior we have in 4.6.0, the keyboard stay closed ! :)
@stevkan thanks for you help ;)

@didaskein didaskein added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. labels Jan 23, 2020
@tdurnford
Copy link
Contributor

@didaskein It looks like this behavior is intended. The suggested action onClick handler calls focusSendBox which should trigger the keyboard to appear. However, I do agree that this creates a clunky user experience for mobile devices. @compulim @corinagum We should consider changing this behavior for mobile or only focus on the send box if it had focus prior to the user clicking the suggested action.

@tdurnford tdurnford added the customer-replied-to Required for internal reporting. Do not delete. label Jan 24, 2020
@corinagum
Copy link
Contributor

There are at least 2 issues related to this topic in previous issues. Can we try and pull those up?

@daveta
Copy link

daveta commented Feb 3, 2020

Hi @didaskein : @tdurnford gave a response. Please reopen if you have any further questions. Thanks.

@daveta daveta closed this as completed Feb 3, 2020
@tdurnford
Copy link
Contributor

Reopening to track this work item

@tdurnford tdurnford reopened this Feb 3, 2020
@compulim
Copy link
Contributor

compulim commented Feb 3, 2020

Prefer not to detect whether it is mobile or not, but put the behavior across both platforms (not focus on send box after click). Because if you use Surface on tablet mode, it could suffer the same problem too.

@compulim
Copy link
Contributor

compulim commented Feb 3, 2020

Please link two issues with this so we can understand the bigger picture.

@corinagum
Copy link
Contributor

#2087
#1789
@tdurnford could you take a look at these?

@carlosscastro
Copy link
Member

@tdurnford @corinagum could you please update this issue? Thanks :)

@cwhitten
Copy link
Member

@compulim to look at suggested actions and focus management on other channels in mobile environments (teams, facebook, etc)

@compulim
Copy link
Contributor

After suggested actions button is clicked, we can focus back to role="complementary" as it has tabIndex="-1". It also have keypress trap to send focus to send box on keydown.

@compulim
Copy link
Contributor

compulim commented Apr 22, 2020

The original fix (no keyboard) was #1971.

But it was reverted because of an accessibility issue #2608.

I am reading the WCAG 2.4.3 Focus Order to see which path we should choose.

@compulim
Copy link
Contributor

FYI, we have a PR for this now, #3213.

@didaskein
Copy link
Author

Thank you guys ! :)

@compulim compulim mentioned this issue May 15, 2020
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants