Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SendBox should have a notification component to manage ConnectivityStatus and TypingIndicator components #2323

Closed
tdurnford opened this issue Aug 16, 2019 · 4 comments
Assignees
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner

Comments

@tdurnford
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

The TypingIndicator component sits on top of the ConnectivityStatus component in theBasicSendBox. At the moment, it is possible for Web Chat to display these two components on the screen at the same time which would clutter the SendBox. Instead of stacking these components, they should behave like the Timestamp and SendStatus components and share the same space. However, the ConnectivityStatus debounces updating the component to display each status for a minimum of 400 ms. This makes it difficult to determine when each component should have ownership over the space.

Describe the suggestion or request in detail
The TypingIndicator and the ConnectivityStatus components should be encapsulated and managed in a NotificationCenter component where each child has a certain priority to determine which one Web Chat should render on the screen.

<NotificationCenter>
  <ConnectivityStatus />
  <TypingIndicator />
</NotificationCenter>

Describe alternatives you have considered

Yea, no.

[Enhancement]

@corinagum
Copy link
Contributor

This kind of goes hand in hand with the very general 'redesign the sendbox' issue we have: #2211, #1839

@corinagum
Copy link
Contributor

Also, this has some a11y considerations I would like to look into, so lmk when you get to this item

@corinagum corinagum removed the Pending label Aug 27, 2019
@corinagum corinagum added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Sep 17, 2019
@corinagum
Copy link
Contributor

New idea discussed by me, @compulim, and @tdurnford:

What if we made a new Toast component, that would allow us to stack notifications, suggested actions, and send typing indicator (and other notifications that the user may want to implement) so that they are no longer a part of the send box (improves simplicity) and allows for a new section of Web Chat that we could call "Status and notifications" or something?

@compulim
Copy link
Contributor

compulim commented Mar 6, 2020

Done.

@compulim compulim closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner
Projects
None yet
Development

No branches or pull requests

3 participants