Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech: Stop microphone button should re-enable the button after a few seconds #2240

Closed
compulim opened this issue Jul 30, 2019 · 0 comments · Fixed by #2241
Closed

Speech: Stop microphone button should re-enable the button after a few seconds #2240

compulim opened this issue Jul 30, 2019 · 0 comments · Fixed by #2241
Assignees
Labels
area-speech bug Indicates an unexpected problem or an unintended behavior. front-burner

Comments

@compulim
Copy link
Contributor

Version

master

Describe the bug

After microphone button is clicked to stop the recording, the button continue to be disabled.

This is because in Dictation.js, we have a check when we should re-enable the button. The button should be allowed to re-enable when STOPPING.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to https://microsoft.github.io/BotFramework-WebChat/06.a.cognitive-services-bing-speech-js/
  2. Click on micrephone button
  3. Speak a very long text
  4. While you are speaking, notice the microphone button turned red
  5. Click the microphone button while it is red, should turn off recording

Expected behavior

Within a few seconds, the microphone button should re-enable and ready to start recording again.

Actual, it did not re-enable and become permanently disabled.

Additional context

This is affecting all types of Web Speech engine, including browser, Bing Speech, and Cognitive Services.

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jul 30, 2019
@compulim compulim changed the title Stop microphone button should not disable the button Stop microphone button should re-enable the button after a few seconds Jul 30, 2019
@compulim compulim self-assigned this Jul 30, 2019
@compulim compulim removed the Pending label Jul 30, 2019
@compulim compulim changed the title Stop microphone button should re-enable the button after a few seconds Speech: Stop microphone button should re-enable the button after a few seconds Jul 30, 2019
@compulim compulim mentioned this issue Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-speech bug Indicates an unexpected problem or an unintended behavior. front-burner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant