Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sip protocol not supported in Web Chat v4 #2057

Closed
tdurnford opened this issue Jun 6, 2019 · 0 comments · Fixed by #2061
Closed

Sip protocol not supported in Web Chat v4 #2057

tdurnford opened this issue Jun 6, 2019 · 0 comments · Fixed by #2061
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner parity The issue describes a gap in parity between two or more platforms.

Comments

@tdurnford
Copy link
Contributor

Description

I noticed Web Chat v3 supports the sip protocol while investigating IcM #124908718; however, it is not supported in Web Chat v4.

Steps to Reproduce

Send an activity with a sip link to Web Chat.

await context.sendActivity('[Sip Link](sip:[email protected])');

Expected Result / v3 Result

<p><a href="sip:[email protected]" target="_blank">Sip Link</a></p>

Actual Result / v4 Result

<p><a target="_blank">Sip Link</a></p>

Fix

We can add the sip protocol to either the allowedSchemes or allowedSchemesByTag attributes in Web Chat's sanitize html options to resolve the issue (sanitize html default options).

const SANITIZE_HTML_OPTIONS = {
  ...
  allowedSchemes : ['http', 'https', 'ftp', 'mailto', 'sip'],
  ... and/or
  allowedSchemesByTag: { a: ['http', 'https', 'ftp', 'mailto', 'sip'] }
};

Additional context

Directly related to issue #199

[Bug]

@tdurnford tdurnford added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jun 6, 2019
@corinagum corinagum added parity The issue describes a gap in parity between two or more platforms. Triage-E front-burner and removed Pending labels Jun 6, 2019
@tdurnford tdurnford self-assigned this Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants