Trying to render invalid AdaptiveCards blows up WebChat/Emulator

[stevengum]

Trying to render improper AdaptiveCard attachments results in the following (using the v4 emulator, build 4.0.218-nightly):

The attachment looks like this:

{
  "contentType": "application/vnd.microsoft.card.adaptive",
  "content": 5
}

This is the error from the dev tools console:

react-dom.production.min.js:151 TypeError: Cannot create property 'version' on number '5'
    at t.mountAdaptiveCards (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:1:117091)
    at t.componentDidMount (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:1:116352)
    at commitLifeCycles (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:72264)
    at x (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:60072)
    at w (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:58882)
    at g (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:58413)
    at _ (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:58250)
    at b (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:57629)
    at c (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:57091)
    at Object.enqueueSetState (file:///C:/Program%20Files%20(x86)/Bot%20Framework%20Emulator/resources/app.asar/node_modules/@bfemulator/client/public/vendors.js:43:46322)

Line of code from vendors.js:

// Line 5009:
    "../../../node_modules/botframework-webchat/built/AdaptiveCardContainer.js": function(e, t, n) {

// Line 5096
t.prototype.mountAdaptiveCards = function() {
  var e = this
  , t = this.props.nativeCard || new o.AdaptiveCard;
  t.hostConfig = this.props.hostConfig || p;
  var n = [];
  if (!this.props.nativeCard && this.props.jsonCard && (this.props.jsonCard.version = this.props.jsonCard.version || "0.5",

[compulim]

In AdaptiveCardContainer.tsx:170, we are setting version on a number, thus, we are getting that error.

We want to make sure exceptions are caught and passed to line 228.

@corinagum can you look at it?

[compulim]

Please verify if it repro in v4. If you need to write a bot to do the job, please use the MockBot and add a new command there. So we can easily track regressions there.

[punitganshani]

Still facing this issue with Webchat and blows out the Emulator. Any fix?

[corinagum]

@punitganshani We are working on a fix and plan to have it for the next milestone. Thanks for your patience!

[corinagum]

Merged

[compulim]

@punitganshani I am fixing the CI/CD, it wasn't working for v3 for a while. Stay tuned, should get a build out soon.

[compulim]

@punitganshani it is in @0.15.1-v3.4da20d6. You can either do npm install botframework-webchat@legacy, or npm install [email protected] to get the fix. Please let us know if it doesn't work for you, we are happy to help.

p.s. CDN at https://cdn.botframework.com/botframework-webchat/legacy/BotChat.js, or https://cdn.botframework.com/botframework-webchat/0.15.1-v3.4da20d6/BotChat.js.