diff --git a/CHANGELOG.md b/CHANGELOG.md index 38cca0a318..77ea86a8cc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -69,12 +69,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - [`sanitize-html@2.1.2`](https://npmjs.com/package/sanitize-html) - [`whatwg-fetch@3.4.1`](https://npmjs.com/package/whatwg-fetch) -## Unreleased +### Fixed -### Changed - Fixes [#3278](https://github.com/microsoft/BotFramework-WebChat/issues/3278). Update `HOOKS.md` verbiage, by [@corinagum](https://github.com/corinagum) in PR [#3564](https://github.com/microsoft/BotFramework-WebChat/pull/3564) - Fixes [#3534](https://github.com/microsoft/BotFramework-WebChat/issues/3534). Remove 2020 deprecations, by [@corinagum](https://github.com/corinagum) in PR [#3564](https://github.com/microsoft/BotFramework-WebChat/pull/3564) - Fixes [#3561](https://github.com/microsoft/BotFramework-WebChat/issues/3561). Remove MyGet mentions from samples, by [@corinagum](https://github.com/corinagum) in PR [#3564](https://github.com/microsoft/BotFramework-WebChat/pull/3564) +- Fixes [#3537](https://github.com/microsoft/BotFramework-WebChat/issues/3537). Fix some carousels improperly using aria-roledescription, by [@corinagum](https://github.com/corinagum) in PR [#3599](https://github.com/microsoft/BotFramework-WebChat/pull/3599) ## [4.11.0] - 2020-11-04 diff --git a/__tests__/html/accessibility.aria-roledescription.html b/__tests__/html/accessibility.aria-roledescription.html index 00d0d9f0da..1ff972b523 100644 --- a/__tests__/html/accessibility.aria-roledescription.html +++ b/__tests__/html/accessibility.aria-roledescription.html @@ -34,9 +34,11 @@ await pageObjects.wait(conditions.uiConnected(), timeouts.directLine); await pageObjects.sendMessageViaSendBox('carousel', { waitForSend: true }); + await pageObjects.sendMessageViaSendBox('layout double', { waitForSend: true }); + await pageObjects.sendMessageViaSendBox('layout carousel', { waitForSend: true }); await pageObjects.sendMessageViaSendBox('Hello world', { waitForSend: true }); await pageObjects.sendMessageViaSendBox('receiptcard', { waitForSend: true }); - await pageObjects.wait(conditions.minNumActivitiesShown(6), timeouts.directLine); + await pageObjects.wait(conditions.minNumActivitiesShown(10), timeouts.directLine); await pageObjects.wait(conditions.scrollToBottomCompleted(), timeouts.directLine); const invalidElements = [].filter.call( @@ -45,7 +47,9 @@ ); invalidElements.length && - console.error('Elements with "aria-roledescription" attribute but not "role" attribute', { invalidElements }); + console.error('Elements with "aria-roledescription" attribute but not "role" attribute:', { + invalidElements + }); expect(invalidElements).toHaveProperty('length', 0); diff --git a/__tests__/html/accessibility.attachment.carouselLayoutRole.html b/__tests__/html/accessibility.attachment.carouselLayoutRole.html index ef14a78d4d..6f145f612b 100644 --- a/__tests__/html/accessibility.attachment.carouselLayoutRole.html +++ b/__tests__/html/accessibility.attachment.carouselLayoutRole.html @@ -39,7 +39,7 @@ const messageRole = document.querySelector('.webchat__stacked-layout__message-row').getAttribute('role'); - expect(messageRole).toEqual('group'); + expect(messageRole).toBeTruthy(); await host.done(); })().catch(async err => { diff --git a/__tests__/html/accessibility.attachment.stackedLayoutRole.html b/__tests__/html/accessibility.attachment.stackedLayoutRole.html index 478bf8eede..14717b21f3 100644 --- a/__tests__/html/accessibility.attachment.stackedLayoutRole.html +++ b/__tests__/html/accessibility.attachment.stackedLayoutRole.html @@ -39,7 +39,7 @@ const attachmentRole = document.querySelector('.webchat__carousel-filmstrip__attachment').getAttribute('role'); - expect(attachmentRole).toEqual('group'); + expect(attachmentRole).toBeTruthy(); await host.done(); })().catch(async err => { diff --git a/packages/component/src/Activity/CarouselFilmStrip.js b/packages/component/src/Activity/CarouselFilmStrip.js index 1d185aebf2..b075d6b1ed 100644 --- a/packages/component/src/Activity/CarouselFilmStrip.js +++ b/packages/component/src/Activity/CarouselFilmStrip.js @@ -196,9 +196,14 @@ const CarouselFilmStrip = ({